Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Backwards Integrations Fail when using the C++ Backend. #56

Open
jrenaud90 opened this issue Jul 17, 2024 · 0 comments
Open

Some Backwards Integrations Fail when using the C++ Backend. #56

jrenaud90 opened this issue Jul 17, 2024 · 0 comments
Labels
bug Something isn't working C++ Backend Issue related to the C++ backend help wanted Extra attention is needed

Comments

@jrenaud90
Copy link
Owner

jrenaud90 commented Jul 17, 2024

See the pytest.skip in the accuracy test in "test_a_pysolve_ivp.py" test file. Most (all?) of these are failing at the np.allclose check. I have manually checked some other cases with backward integration and it worked fine. Not sure what the trigger is.

This is likely to do with the backend's messy indexing when it comes to forward and backward integration. Code could really use a second pair of eyes to help clean it up and squash those bugs.

Will need to check that any index fixes still work for backward integration with t_eval and dense_output are set.

@jrenaud90 jrenaud90 changed the title placeholder Some Backwards Integrations Fail when using the C++ Backend. Jul 17, 2024
@jrenaud90 jrenaud90 added help wanted Extra attention is needed C++ Backend Issue related to the C++ backend bug Something isn't working labels Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working C++ Backend Issue related to the C++ backend help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant