Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CySolver and cyrk_ode optional arguments and extra output must be float64s numbers #31

Open
jrenaud90 opened this issue Jul 28, 2023 · 1 comment
Open

CySolver and cyrk_ode optional arguments and extra output must be float64s numbers #31

jrenaud90 opened this issue Jul 28, 2023 · 1 comment
Labels
cryk_ode Issues related to the cyrk_ode function CySolver Issues related to the CySolver class cython Issue related to cython-based code enhancement New feature or request

Comments

@jrenaud90
Copy link
Owner

For performance and simplicity reasons, it was decided that the optional arguments (args) passed to both the CySolver and cyrk_ode solvers must be given as floating point numbers (no complex values, strings, booleans, etc). It would be nice to offer the ability to pass other types of values via the args parameter.

For the same reasons, the optional capture of additional outputs for both solvers is also limited to certain types (floats for CySolver; floats or complex for cyrk_ode).
@jrenaud90 jrenaud90 added enhancement New feature or request cython Issue related to cython-based code labels Jul 28, 2023
jrenaud90 added a commit that referenced this issue Aug 27, 2023
@jrenaud90
Can now use arrays for tols. Addressing Issue #31
67358c2
@jrenaud90 jrenaud90 mentioned this issue Aug 28, 2023
Merged
@jrenaud90
Copy link
Owner Author

Commit 67358c2 and tag v0.7.0 mistakenly cited this issue. It did not address this.

@jrenaud90 jrenaud90 added CySolver Issues related to the CySolver class cryk_ode Issues related to the cyrk_ode function labels Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cryk_ode Issues related to the cyrk_ode function CySolver Issues related to the CySolver class cython Issue related to cython-based code enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jrenaud90