Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docker build, include tls.Config in http.Server #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix docker build, include tls.Config in http.Server #12

wants to merge 1 commit into from

Conversation

sdsznsk
Copy link

@sdsznsk sdsznsk commented Jan 18, 2023 •
edited
Loading

When merged this pull request will:

  • Fix error in local docker build
$ git clone https://github.com/jpweber/cole.git
$ cd cole
$ docker build -t cole .
---------- SNIP --------------
Step 6/12 : RUN CGO_ENABLED=0 go build -a -ldflags '-s' -installsuffix cgo -o app .
 ---> Running in 92fe8e2f38e9
# github.com/jpweber/cole
./main.go:126:2: invalid character U+0023 '#'
./main.go:127:7: no new variables on left side of :=
The command '/bin/sh -c CGO_ENABLED=0 go build -a -ldflags '-s' -installsuffix cgo -o app .' returned a non-zero code: 2
  • Include defined tls.Config in http.Server

Resolves #11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docker build fails
1 participant
@sdsznsk