Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle duplicate columns in spreadsheet upload #303

Open
jpschewe opened this issue Oct 29, 2014 · 3 comments
Open

Handle duplicate columns in spreadsheet upload #303

jpschewe opened this issue Oct 29, 2014 · 3 comments
Assignees
Milestone

Comments

@jpschewe
Copy link
Owner

If the user has 2 columns with the same name we should handle that. Perhaps just prefix each column number with its index. If we do this we should update the web pages to tell the user that is what they are seeing.

@jpschewe jpschewe self-assigned this Oct 6, 2023
@jpschewe jpschewe added this to the 18.0 milestone Oct 6, 2023
@jpschewe
Copy link
Owner Author

jpschewe commented Oct 7, 2023

Looking at this I want to modify all code that uses UploadSpreadsheet to use the column information parsed in StoreColumnInformation. This should not throw out blank or null column names. It should prefix the column name with the index so that all column names are unique. It should also sanitize the column names to be safe as database column names.

All downstream code should then skip past the header row and use the previously processed information for column headers. This will include checking the parsed headers to get the index of the column to find the needed data.

@jpschewe
Copy link
Owner Author

jpschewe commented Oct 7, 2023

Thinking of having an object that contains

  • File
  • List<@Nullable String> original headers
  • List<String> sanitized headers - safe for database use, non-null
  • int header row index
  • @Nullable String sheet name

@jpschewe
Copy link
Owner Author

jpschewe commented Oct 7, 2023

Tasks:

  • modify javascript automatic column select to check end of string rather than whole string
  • modify Java automatic column select to find option where end of string matches
  • Modify FullTournamentTest to check for option ending with the specified string for column names
  • Remove sanitize from the stored column information (update documentation as well). Only sanitize when going to a database column.
  • When uploading team data, leave the columns unsanitized, however do the translation on the back end

@jpschewe jpschewe modified the milestones: 18.0, 18.1 Oct 13, 2023
@jpschewe jpschewe modified the milestones: 18.1, 18.2 Nov 10, 2023
@jpschewe jpschewe modified the milestones: 18.2, 18.3 Dec 2, 2023
@jpschewe jpschewe modified the milestones: 18.3, 18.4 Jan 3, 2024
@jpschewe jpschewe modified the milestones: 18.4, 19.0 Feb 6, 2024
@jpschewe jpschewe modified the milestones: 19.0, 19.1 Aug 8, 2024
@jpschewe jpschewe modified the milestones: 19.1, 19.2 Jan 2, 2025
@jpschewe jpschewe modified the milestones: 19.2, 20.0 Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant