Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User/pass auth flow now unsupported (Spotify API change) #515

Closed
jacksongoode opened this issue Aug 12, 2024 · 5 comments
Closed

User/pass auth flow now unsupported (Spotify API change) #515

jacksongoode opened this issue Aug 12, 2024 · 5 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@jacksongoode
Copy link
Collaborator

jacksongoode commented Aug 12, 2024

Describe the bug
librespot-org/librespot#1308

Spotify just recently made this change within the last couple days. It breaks all 3rd party apps with this login method. This likely means we'll need to rework the authentication flow since we can't use username and passwords. This will need to be addressed immediately.

To Reproduce
Clear cache & sign in.

@jacksongoode jacksongoode added bug Something isn't working help wanted Extra attention is needed labels Aug 12, 2024
@ewancg
Copy link

ewancg commented Aug 12, 2024

Is there a known alternative auth method?

@kingosticks
Copy link

@jacksongoode regarding your comment in #1309, I am curious, given you've re-implemented much of librespot already here, why not do that for the oauth stuff too? There's not that much to it (even less if you take a simpler approach to the actual oauth bit and omit the superfluous ExtraTokenFields). You might be waiting a while for it to be merged otherwise.

@jacksongoode
Copy link
Collaborator Author

Working on a PR to implement the login5 method.

@kingosticks
Copy link

If you just want to fix this particular problem and get login working again, you don't need login5. You only really need to some oauth gubbins stuff to get an access token, then login with it using AuthenticationType::AUTHENTICATION_SPOTIFY_TOKEN to obtain reusable credentials, and then re-auth the session with those reusable credentials.

I mixed Login5 support into my PR because we previously had problems obtaining additional tokens (via tokenmaster) with a AUTHENTICATION_SPOTIFY_TOKEN-authed session but it seems Spotify have fixed that. I think I will remove all the Login5 stuff from my PR since it belong in a separate PR. Thanks for making me realise!

@arch-btw
Copy link
Contributor

arch-btw commented Sep 3, 2024

Thank you @jacksongoode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants