We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
image/jpg
image/jpeg
Describe the bug
If given e.g. https://example.com/foo.jpg, formatEnclosure gives type="image/jpg" instead of the correct MIME type image/jpeg.
https://example.com/foo.jpg
formatEnclosure
type="image/jpg"
I haven't checked which clients actually care about this.
To Reproduce
This behavior is already visible in the tests:
feed/src/__tests__/__snapshots__/rss2.spec.ts.snap
Line 34 in fd77835
Expected behavior
The generated feed should contain:
<enclosure ... type="image/jpeg"/>
Actual behavior
The generated feed contains:
<enclosure ... type="image/jpg"/>
Versions (please complete the following information):
Additional context
The code at https://github.com/jpmonette/feed/blob/master/src/rss2.ts#L215-L223 returns the MIME type as image/[file_extension], which is correct for e.g. .png and .gif, but incorrect for e.g. .jpg and .svg.
image/[file_extension]
.png
.gif
.jpg
.svg
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Describe the bug
If given e.g.
https://example.com/foo.jpg
,formatEnclosure
givestype="image/jpg"
instead of the correct MIME typeimage/jpeg
.I haven't checked which clients actually care about this.
To Reproduce
This behavior is already visible in the tests:
feed/src/__tests__/__snapshots__/rss2.spec.ts.snap
Line 34 in fd77835
Expected behavior
The generated feed should contain:
Actual behavior
The generated feed contains:
Versions (please complete the following information):
Additional context
The code at https://github.com/jpmonette/feed/blob/master/src/rss2.ts#L215-L223 returns the MIME type as
image/[file_extension]
, which is correct for e.g..png
and.gif
, but incorrect for e.g..jpg
and.svg
.The text was updated successfully, but these errors were encountered: