Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for related searches #361

Open
jpdillingham opened this issue Aug 21, 2020 · 3 comments
Open

Add support for related searches #361

jpdillingham opened this issue Aug 21, 2020 · 3 comments
Labels
deferred We'll do this later feature New feature or request help wanted Extra attention is needed
Projects
Soulseek.NET

Comments

@jpdillingham
Copy link
Owner

jpdillingham commented Aug 21, 2020 •
edited
Loading

While investigating #353 it has been discovered that outgoing search requests are accompanied by an additional message with code 153, which informs the server of our search and solicits a list of related searches.

The messages are documented here.
@jpdillingham jpdillingham added the feature New feature or request label Aug 21, 2020
@jpdillingham jpdillingham added this to the 1.0.0 milestone Aug 21, 2020
@jpdillingham jpdillingham added this to Backlog in Soulseek.NET via automation Aug 21, 2020
@mathiascode
Copy link
Contributor

SoulseekQt post from 2011: https://www.slsknet.org/news/node/303

I wonder if this feature has been retired though. I tried searching for a bunch of popular artists and music, but no related search terms appeared. Others have also had issues with this: https://www.reddit.com/r/Soulseek/comments/9yddfl/similarsuggestedrecommended_searches/

@jpdillingham jpdillingham added deferred We'll do this later help wanted Extra attention is needed labels Aug 23, 2020
@jpdillingham jpdillingham modified the milestones: 1.0.0, 1.1.0 Aug 23, 2020
@jpdillingham
Copy link
Owner Author

Thanks for the additional context. After giving it some thought I think this feature is fairly similar to the recommendation (#212) system which also appears to be deprecated.

@jpdillingham jpdillingham removed this from the 1.1.0 milestone Dec 16, 2020
@jpdillingham
Copy link
Owner Author

I've removed this from the roadmap as I believe it to be deprecated (or perhaps just broken) server-side. I'll leave the issue open for now in case anyone wants to investigate further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
deferred We'll do this later feature New feature or request help wanted Extra attention is needed
Projects
Soulseek.NET
  
Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mathiascode @jpdillingham