Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decoupling of UI and convolver update logic #11

Open
jpcima opened this issue Jun 30, 2018 · 1 comment
Open

Decoupling of UI and convolver update logic #11

jpcima opened this issue Jun 30, 2018 · 1 comment

Comments

@jpcima
Copy link
Owner

jpcima commented Jun 30, 2018

In current state of HR2, the parameter changes cause the convolver to be recomputed in the GUI task and to be submitted to the audio processor.

What problem arises from this? it's an issue when the plugin is run in background without a GUI. (for example, when loaded from Ardour DAW, as @sub26nico has reported)
It cannot compute changes of parameters, until the GUI gets launched.

In order to fix this, the convolver update logic must be moved to a working task independent from GUI.
When I checked, there was not a trivial way to attack the problem, it needs to reorganize elements of plugin. This is not helped by fact that some elements which participate in convolver updates are deeply tied to logic of the GUI.

To solve it, I have engaged in work to rearrange into a less coupled software design.
After completing this, it will be welcome to do another round of testing.

@alikthename
Copy link

also it doesn't remember last preset selected when ardour project reopened

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants