Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for Tiingo financial statements API #301

Open
ethanbsmith opened this issue Mar 2, 2020 · 9 comments · May be fixed by #352
Open

add support for Tiingo financial statements API #301

ethanbsmith opened this issue Mar 2, 2020 · 9 comments · May be fixed by #352

Comments

@ethanbsmith
Copy link
Contributor

@tiingo is working on a financial statement API: https://api.tiingo.com/documentation/fundamentals

I think we should support this through the getFinancials function (which currently has no live implementations)

I'll get started on a PR, unless there are any objections

@joshuaulrich
Copy link
Owner

Thanks for suggesting this! I 100% agree with adding it. My only recommendation is that we wait until it's out of beta before including it in a quantmod release. Feel free to start coding and testing though!

@ethanbsmith
Copy link
Contributor Author

Apologies to all. I have not had a chance to work on this and it just keeps getting bumped down in priority for me. I do hope to get to it at some point, but probably will not be for a good while longer

@joshuaulrich
Copy link
Owner

No need to apologize! I mentioned this in 327 because it's an example of what needs to be done for getFinancials() to start working again.

@ethanbsmith
Copy link
Contributor Author

ethanbsmith commented Dec 26, 2021

primitive baseline initial functionality. still very much a WIP. feedback welcome:
https://github.com/ethanbsmith/quantmod/tree/301_tiingo_financial_statements

@ethanbsmith
Copy link
Contributor Author

Hi @tiingo, we have a working version of this. is this financial statement API still considered to be beta?

@ethanbsmith
Copy link
Contributor Author

ran into an issue today while and want to log it for posterity:

for Symbol SOFI, notice that items 3 is missing a cashFlow, and items 6 and 7 are missing a balanceSheet. Since the structure is irregular, you cannot use simplifyDataFrame = TRUE in jsonlite::fromJSON (which is the default).

image

@joshuaulrich
Copy link
Owner

joshuaulrich commented Jan 16, 2022

Thanks for the report Ethan!

@tiingo, is this expected behavior? Would it be possible to make the JSON always have the same fields, even if they're empty/null?

@ethanbsmith

This comment has been minimized.

@ethanbsmith
Copy link
Contributor Author

ethanbsmith commented Jan 16, 2022

Response from tiingo:
"In general, pro forma statements issued by companies (statements a company issued prior to their IPO), are often incomplete. For pro forma statements, you can expect missing balance/income/cash flow statements". in this case, SOFI listed on 2020-11-30

needed changes have been pushed:
https://github.com/ethanbsmith/quantmod/blob/301_tiingo_financial_statements/R/getFinancials.R

@ethanbsmith ethanbsmith linked a pull request Jan 19, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants