Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework API to take time.Time #12

Open
Psykar opened this issue Aug 25, 2021 · 1 comment
Open

Rework API to take time.Time #12

Psykar opened this issue Aug 25, 2021 · 1 comment

Comments

@Psykar
Copy link
Contributor

Psykar commented Aug 25, 2021

A few methods in the API take year/month/day/hour/minute/second
Would you be against changing this to take a time.Time object instead?

We could either bump up major versions (v2) or just add a new set of methods that live side by side.

Thoughts?

@joshuaferrara
Copy link
Owner

My initial desire was to port the library as close to the original as possible. I'd think for convenience sake though, converting the API to take time.Time would be appropriate and something that I'd look forward to. I also can't think of any good reason to hold back the library from using what modern constructs are available in Go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants