Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How do you create a bloom filter and add elements to it? #1

Open
gubatron opened this issue Oct 24, 2019 · 1 comment
Open

How do you create a bloom filter and add elements to it? #1

gubatron opened this issue Oct 24, 2019 · 1 comment
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@gubatron
Copy link

gubatron commented Oct 24, 2019

I only see functions to perform checks on a bloom filter, but no functions to create one and add elements to it. Not sure how I'd be able to use the library without a bloom filter in the first place.
Does solidity or web3 provide bloom filter primitives?

@joshstevens19
Copy link
Owner

joshstevens19 commented Oct 24, 2019

Hey @gubatron thanks a lot for raising this issue. The library was initially created for easy looks ups from “logBlooms” and topic blooms which are returned on blocks from Ethereum itself (so ethereum give you the blooms). This libs functions are used in big ethereum libraries like web3js as utils for developers to query data against the blooms given to them on every new block. So it only exposes functions which you pass it a value and a bloom and it tells you if it exists in that bloom filter or not.

Happy to extend this library to have ability to create a new bloom, add to it and remove elements from it for sure. Is that something you would like to see in this library?

I’m on vacation till Monday but will look when back. Let me know if you would like to see anymore then:

  • create new bloom filter
  • ability to add a value to the bloom
  • ability to remove a value to the bloom

Thanks 👍

@joshstevens19 joshstevens19 added the enhancement New feature or request label Oct 24, 2019
@joshstevens19 joshstevens19 self-assigned this Oct 24, 2019
@joshstevens19 joshstevens19 added good first issue Good for newcomers help wanted Extra attention is needed labels Oct 3, 2020
Repository owner deleted a comment from vegeta321311 Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants
@gubatron @joshstevens19 and others