fix: clippy suggestions

Author: joshka

examples/coloring_example.rs

@@ -42,8 +42,8 @@ fn set_foreground_color() -> Result<()> {
 
     // background intensity is a separate value in attrs,
     // wee need to check if this was applied to the current bg color.
-    if (attrs & 0x0080 as u16) != 0 {
-        color = color | 0x0080 as u16;
+    if (attrs & 0x0080_u16) != 0 {
+        color |= 0x0080_u16;
     }
 
     // set the console text attribute to the new color value.

src/cfi.rs

@@ -1,7 +1,7 @@
 use std::fmt;
 use std::mem::zeroed;
 
-use winapi::um::wincontypes::CONSOLE_FONT_INFO;
+use windows_sys::Win32::System::Console::CONSOLE_FONT_INFO;
 
 use crate::Size;
 
@@ -40,3 +40,9 @@ impl FontInfo {
         self.0.nFont
     }
 }
+
+impl Default for FontInfo {
+    fn default() -> Self {
+        Self::new()
+    }
+}

src/console.rs

@@ -213,7 +213,7 @@ impl Console {
     /// a u32.
     fn read_input(&self, buf: &mut [INPUT_RECORD]) -> Result<usize> {
         let mut num_records = 0;
-        debug_assert!(buf.len() < std::u32::MAX as usize);
+        debug_assert!(buf.len() < u32::MAX as usize);
 
         result(unsafe {
             ReadConsoleInputW(

src/csbi.rs

@@ -75,6 +75,12 @@ impl ScreenBufferInfo {
     }
 }
 
+impl Default for ScreenBufferInfo {
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
 impl From<CONSOLE_SCREEN_BUFFER_INFO> for ScreenBufferInfo {
     fn from(csbi: CONSOLE_SCREEN_BUFFER_INFO) -> Self {
         ScreenBufferInfo(csbi)

src/screen_buffer.rs

@@ -3,13 +3,13 @@
 use std::io::Result;
 use std::mem::size_of;
 
-use windows_sys::Win32::Security::SECURITY_ATTRIBUTES;
 use windows_sys::Win32::Storage::FileSystem::{FILE_SHARE_READ, FILE_SHARE_WRITE};
 use windows_sys::Win32::System::Console::{
     CreateConsoleScreenBuffer, GetConsoleScreenBufferInfo, SetConsoleActiveScreenBuffer,
     SetConsoleScreenBufferSize, CONSOLE_TEXTMODE_BUFFER, COORD,
 };
 use windows_sys::Win32::System::SystemServices::{GENERIC_READ, GENERIC_WRITE};
+use windows_sys::Win32::{Security::SECURITY_ATTRIBUTES, System::Console::GetCurrentConsoleFont};
 pub const TRUE: ::windows_sys::Win32::Foundation::BOOL = 1;
 
 use super::{handle_result, result, FontInfo, Handle, HandleType, ScreenBufferInfo};

src/structs/coord.rs

@@ -35,8 +35,8 @@ impl From<Coord> for COORD {
     }
 }
 
-impl Into<(u16, u16)> for Coord {
-    fn into(self) -> (u16, u16) {
-        (self.x as u16, self.y as u16)
+impl From<Coord> for (u16, u16) {
+    fn from(val: Coord) -> Self {
+        (val.x as u16, val.y as u16)
     }
 }

src/structs/size.rs

@@ -24,8 +24,8 @@ impl From<COORD> for Size {
     }
 }
 
-impl Into<(u16, u16)> for Size {
-    fn into(self) -> (u16, u16) {
-        (self.width as u16, self.height as u16)
+impl From<Size> for (u16, u16) {
+    fn from(val: Size) -> Self {
+        (val.width as u16, val.height as u16)
     }
 }