Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate deprecated Recommendations API #51

Open
miparnisari opened this issue Mar 19, 2018 · 5 comments
Open

Migrate deprecated Recommendations API #51

miparnisari opened this issue Mar 19, 2018 · 5 comments

Comments

@miparnisari
Copy link
Collaborator

New API Reference: https://github.com/Microsoft/Product-Recommendations/blob/master/doc/api-reference.md

@jake32321
Copy link

Hey could I possibly take a crack at this? Could I possibly get a little more information on what needs to be done?

@miparnisari
Copy link
Collaborator Author

Hi @jake32321 !

Microsoft recently updated the recommendations API and changed a bunch of things. So the task is to update the wrapper for this service.

The source code is here and the tests are here.

I've written the code for only one API endpoint, but there are more. The task is to write the functions for all (and obviously the tests).

image

You will need a personal Azure subscription to test this. I think they have a free tier (B1) but i haven't checked if it's actually free.

There are some interesting things, like for example the test for the POST /api/models endpoints will have to have a file uploaded to blob storage. It'd be nice to upload and delete this file in the before and after test functions :)

@jake32321
Copy link

Sounds good! I'll get to cracking on this later.

@sabina-rohman
Copy link

@miparnisari Hi, I am first timer. Is this ticket still open? I would like to give it a try?

@miparnisari
Copy link
Collaborator Author

@sabina-rohman sure :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants