Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail to build on OS X #4

Open
abitrolly opened this issue Aug 4, 2021 · 1 comment
Open

Fail to build on OS X #4

abitrolly opened this issue Aug 4, 2021 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@abitrolly
Copy link
Contributor

There is an error while building tdu for OS X.

# github.com/josephpaul0/tdu
./tdu.go:154:18: too many arguments in call to getTtyWidth
	have (*s_scan)
	want ()
./tdu.go:848:9: assignment mismatch: 2 variables but osInit returns 1 values
./tdu.go:867:7: too many arguments in call to osEnd
./tdu_generic.go:35:18: undefined: sc_scan

I've made a Homebrew package for tdu, and the error is reported by Homebrew CI - https://github.com/abitrolly/homebrew-tap/runs/3234326039#step:8:30

@josephpaul0 josephpaul0 self-assigned this Aug 15, 2021
@josephpaul0 josephpaul0 added this to the 1.38 milestone Aug 15, 2021
@josephpaul0 josephpaul0 added the bug Something isn't working label Aug 15, 2021
@josephpaul0
Copy link
Owner

Hello,
There is a regression for Mac OS X.
In tdu_generic.go
func getTtyWidth() int { return 80 }
should be replaced with :
func getTtyWidth(sc *s_scan) int { return 80 }

Several compilation errors seem to be triggered by the missing sc *s_scan
I will look into all errors and provide a patch.

Regards

abitrolly added a commit to abitrolly/tdu that referenced this issue Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants