OVFTool password escaping space character

[carlhprime]

The url.QueryEscape parameter is used to escape the password provided to OVFTool in the locator string:

terraform-provider-esxi/esxi/resource_guest.go

Line 278 in 430848e

password := url.QueryEscape(c.esxiPassword)

terraform-provider-esxi/esxi/guest-create.go

Line 220 in 4ae1327

password := url.QueryEscape(c.esxiPassword)

Unfortunately, the url.QueryEscape function escapes spaces as +, which OVFTool treats as a literal +. Consequently, providing a password containing spaces characters will cause authentication failure.

I just hit this issue, and I would be happy to submit a pull request to perform the additional escape of space manually.

I would personally rather modify the provider to pass credentials to OVFTool via stdin. This would avoid the need for escaping altogether, and would also be better practice in terms of security. If you are willing to go this way then I'll submit a pull request.

[josenk]

I'm OK with either solution, but it must work cross-platform. Please make sure your solution works with Linux, Windows and Mac.

You'll notice that Windows requires a temporary batch file. I remember having a lot of trouble properly handling quotes and escaping on Windows.

terraform-provider-esxi/esxi/guest-create.go

Lines 245 to 280 in 4ae1327

	if runtime.GOOS == "windows" {
	osShellCmd = "cmd.exe"
	osShellCmdOpt = "/c"
	ovf_cmd = strings.Replace(ovf_cmd, "'", "\"", -1)
	var ovf_bat = "ovf_cmd.bat"
	_, err = os.Stat(ovf_bat)
	// delete file if exists
	if os.IsExist(err) {
	err = os.Remove(ovf_bat)
	if err != nil {
	return "", fmt.Errorf("Unable to delete %s: %s\n", ovf_bat, err.Error())
	}
	}
	// create new batch file
	file, err := os.Create(ovf_bat)
	if err != nil {
	return "", fmt.Errorf("Unable to create %s: %s\n", ovf_bat, err.Error())
	defer file.Close()
	}
	_, err = file.WriteString(strings.Replace(ovf_cmd, "%", "%%", -1))
	if err != nil {
	return "", fmt.Errorf("Unable to write to %s: %s\n", ovf_bat, err.Error())
	defer file.Close()
	}
	err = file.Sync()
	defer file.Close()
	ovf_cmd = ovf_bat
	} else {

If your solution can remove the requirement of the temp batch file, that would be a great fix!

Thanks.