Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add preprocessor #38

Open
josefaidt opened this issue Sep 8, 2021 · 0 comments
Open

add preprocessor #38

josefaidt opened this issue Sep 8, 2021 · 0 comments
Assignees
@josefaidt
Labels
type/feature A new feature or functionality

Comments

@josefaidt
Copy link
Owner

josefaidt commented Sep 8, 2021 •
edited
Loading

Description

Add a preprocessor (ref #32) to generate CSS file for external consumption or preprocess into the ThemeWrapper style block (with global styles), negating the need for the current JS-based solution to load on mount.

Thoughts

  • how do we determine whether preprocessor is in use (e.g. when do we not execute the onMount behavior)?
  • do we add styles to ThemeWrapper style block with :global(html) or :root? Does this have unintended behaviors with initial load?
  • add an option to "eject" the created stylesheet for external consumption
@josefaidt josefaidt self-assigned this Sep 8, 2021
@josefaidt josefaidt added the type/feature A new feature or functionality label Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josefaidt josefaidt

Labels
type/feature A new feature or functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@josefaidt