Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add placeholder function so executing scripts with inbuilt unit tests don't error #65

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

t-nil
Copy link

@t-nil t-nil commented Jan 16, 2024

It seems also, that your current form of creating these functions (@test, @echo) in fishtape and string collecting them into the newly spawned shell wouldn't work anymore, because you erase those functions globally. Maybe putting them in a special file.

Or actually, just making them available to the user, ergo moving them to functions/@{echo,test}.fish would also be totally acceptable from my perspective. They interfere with global function space anyway. Then an env could be added to check if the script is called by fishtape.

What do you think?

@jorgebucaran
Copy link
Owner

Could you clarify what you mean when you say the functions would no longer work in the newly spawned shell? As far as I am concerned, Fishtape has been functioning correctly for at least the past three years. Has something changed or broken?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants