From f7cbca0f51b25540ac6284aaf77c14fa92249f44 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89douard=20Lopez?= <edouard.lopez@manomano.com>
Date: Wed, 24 Jan 2024 16:13:08 +0100
Subject: [PATCH] fix: increase _fishtape_test_failed when file is invalid

source ./functions/fishtape.fish; fishtape ./tests/invalid.fish

see #60
---
 .github/workflows/ci.yml | 3 ++-
 functions/fishtape.fish  | 3 ++-
 tests/invalid.fish       | 4 ++++
 3 files changed, 8 insertions(+), 2 deletions(-)
 create mode 100644 tests/invalid.fish

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 6c8ab80..d409f27 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -18,5 +18,6 @@ jobs:
         run: |
           curl -sL https://git.io/fisher | source
           fisher install $GITHUB_WORKSPACE
-          fishtape tests/*
+          fishtape tests/invdalid.fish || true # should fail
+          fishtape (string match -v '*invalid*' -- tests/*)
         shell: fish {0}
diff --git a/functions/fishtape.fish b/functions/fishtape.fish
index 7759f92..b15c2fe 100644
--- a/functions/fishtape.fish
+++ b/functions/fishtape.fish
@@ -94,7 +94,8 @@ function fishtape --description "Test scripts, functions, and plugins in Fish"
             echo TAP version 13
 
             for file in $files
-                fish --init-command=(functions @echo | string collect) --init-command=(functions @test | string collect) $file
+                fish --init-command=(functions @echo | string collect) --init-command=(functions @test | string collect) $file \
+                    || set _fishtape_test_failed (math $_fishtape_test_failed + 1)
             end
 
             echo
diff --git a/tests/invalid.fish b/tests/invalid.fish
new file mode 100644
index 0000000..d5a463e
--- /dev/null
+++ b/tests/invalid.fish
@@ -0,0 +1,4 @@
+@echo === invalid ===
+
+@test "a valid test but invalid file" true = true
+end # we want to trigger a parsing error