Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add type declaration file #25

Open
mizlan opened this issue Dec 15, 2023 · 5 comments
Open

[Feature Request] Add type declaration file #25

mizlan opened this issue Dec 15, 2023 · 5 comments

Comments

@mizlan
Copy link

mizlan commented Dec 15, 2023

Screenshot 2023-12-15 at 2 55 01 PM

Getting the warning, was wondering if you'd consider adding the type declaration file.

@jorenvanhee
Copy link
Owner

Good idea :) I guess it would be more or less the same like the type declaration file in the tailwindcss/typography plugin? Would be more than happy to merge a PR.

@mizlan
Copy link
Author

mizlan commented Dec 21, 2023

I'll send a PR soon!

@mizlan
Copy link
Author

mizlan commented Dec 25, 2023

As I was browsing some documentation, I was curious why you specify configuration to be defined in theme instead of in an options argument like Typography:

https://tailwindcss.com/docs/typography-plugin#changing-the-default-class-name

Seems like the latter makes more sense, since there is locality between the plugin and the configuration

@jorenvanhee
Copy link
Owner

I built this plugin back in the Tailwind CSS 1.x days and that happened to be the recommended way. I see that they now recommend another way indeed.

I guess it would be easier to add the types once the new recommended options are implemented?

@mizlan
Copy link
Author

mizlan commented Dec 29, 2023

Yeah, probably? I have a file that is sufficient to stop the warning in my original screenshot but I can add another call with an options object and it doesn't error. Don't know if that can be prevented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants