-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] Add type declaration file #25
Comments
Good idea :) I guess it would be more or less the same like the type declaration file in the tailwindcss/typography plugin? Would be more than happy to merge a PR. |
I'll send a PR soon! |
As I was browsing some documentation, I was curious why you specify configuration to be defined in https://tailwindcss.com/docs/typography-plugin#changing-the-default-class-name Seems like the latter makes more sense, since there is locality between the plugin and the configuration |
I built this plugin back in the Tailwind CSS 1.x days and that happened to be the recommended way. I see that they now recommend another way indeed. I guess it would be easier to add the types once the new recommended options are implemented? |
Yeah, probably? I have a file that is sufficient to stop the warning in my original screenshot but I can add another call with an options object and it doesn't error. Don't know if that can be prevented. |
Getting the warning, was wondering if you'd consider adding the type declaration file.
The text was updated successfully, but these errors were encountered: