Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GB-001 Remove the need for main package in common folder. #12

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

seank90
Copy link

@seank90 seank90 commented Jan 1, 2020

Hi John,

I noticed you have a main folder with only a AndroidManifest file within.

I removed the folder and added the sources to the Android configuration within the SharedCode package. This will remove the need for a main package within the SharedCode.

Looking into Multiplatform and found this example extremely useful. Thank you :)

Changes:

  • Remove Main package from SharedCode.
  • Added the source targets for the Android Config in SharedCode build.gradle.
  • Moved the manifest to the androidMain package.

Test

  • Cleaned the cache and rebuilt gradle

  • Ran the App again with a clean build

  • Success.

@joreilly
Copy link
Owner

joreilly commented Jan 1, 2020

Thanks @seank90 for creating this....will take a look shortly. BTW regarding trying out multiplatform stuff, you might also find https://github.com/joreilly/PeopleInSpace useful....it's a much smaller project that I created recently to allow focussing on key moving parts.....the galway bus project still has quite a bit of "legacy" code in it including significant parts that haven't been migrated over yet to use shared code etc (I also just pushed a commit to it short while ago that starts to clean things up a bit)

@seank90
Copy link
Author

seank90 commented Jan 1, 2020

I noticed some legacy stuff alright. Nothing wrong with having a useful working project to work off. God forbid that Galway could use a decent bus app. (I'm a tribesman myself).

I had a look at People in Space. I have one issue with it that this project seems to clear up a bit and that is Kotlin Multiplatform persistence. I have tried and failed multiple times due to either bugs in the compiler with KN and Multiplatform or have not been setting Gradle correctly, but this is one of the more complete applications with all layers inclusive. Pushing to tidying this up is much better for a template as it is a system that lends itself to multiple forms of tech in the mobile space such as Maps, Servers, Persistence, Personal Timetables etc.

I currently work for a Transport Platform and Build SDK's on two platforms (4 in total) Networking Layers and UI Layers for both iOS and Android. So getting a Multiplatform project to work will really help unify the networking layer and also allow me to expose a JS NPM lib with networking for web as part of the companies SDK offering.

You should also check out this project if you are interested in the space. They are up to some very cool MP stuff.

https://github.com/icerockdev/moko-template

@joreilly joreilly force-pushed the master branch 2 times, most recently from dc52b8f to 83379ae Compare September 5, 2020 10:36
Base automatically changed from master to main January 16, 2021 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants