Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add placeholder support #40

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add placeholder support #40

wants to merge 2 commits into from

Conversation

amazeika
Copy link
Member

fixes #39

Test Instructions

Add 'attribs' => ['placeholder' => 'Type your stuff here'] to the config object when instantiating the editor to add a placeholder.

@amazeika amazeika requested a review from jebbdomingo May 21, 2019 15:30
@amazeika amazeika self-assigned this May 21, 2019
@amazeika
Copy link
Member Author

@jebbdomingo Ercan told me that you've tried this in the past. I've managed to support placeholder text on ckeditor 4 with confighelper plugin. Please try it out and see if it works for you. Added it to improve the comments support for LEADman.

Copy link
Member

@jebbdomingo jebbdomingo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amazeika Apologies, I just noticed this ticket.
The editor isn't displayed and there's a js error
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support placeholder on editor
2 participants