Skip to content

Conversation

@richard67
Copy link
Member

@richard67 richard67 commented Oct 17, 2025

Pull Request for Issue # .

Summary of Changes

This pull request (PR) updates the composer dependency "joomla/test" from version 4.0 to version 4.0.1 for the 6.0-dev branch.

The only change pulled with this update is the one from PR joomla-framework/test#19 to fix a deprecation notice on PHP 8.5 for the setAccessible() methods of various Reflection objects.

Release note: https://github.com/joomla-framework/test/releases/tag/4.0.1 .

See also https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_reflectionsetaccessible .

Testing Instructions

  • Use php 8.5 (latest pre-version).
  • Run composer install
  • Run unit tests ./libraries/vendor/bin/phpunit --testsuite Unit
  • Check PHP error log

Actual result BEFORE applying this Pull Request

Deprecation messages ReflectionMethod::setAccessible() is deprecated.

Expected result AFTER applying this Pull Request

None of these messages for the joomla/tes depencendies.

Remaining messages will be fixed when the changes from PR #46202 in 5.4-dev have been merged up into 6.0-dev:

administrator/components/com_scheduler/src/Traits/TaskPluginTrait.php
tests/Unit/Libraries/Cms/Feed/FeedFactoryTest.php
tests/Unit/Libraries/Cms/Feed/Parser/AtomParserTest.php
tests/Unit/Libraries/Cms/Feed/Parser/RssParserTest.php
tests/Unit/Libraries/Cms/Microdata/MicrodataTest.php
tests/Unit/Libraries/Cms/Updater/ConstraintCheckerTest.php
tests/Unit/Libraries/Cms/Updater/TufAdapterTest.php

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@muhme
Copy link
Contributor

muhme commented Oct 17, 2025

I have tested this item 🔴 unsuccessfully on fa47705

Tested with JBT, PHP 8.5.0RC2

  • Before the PR seen 76 ReflectionMethod::setAccessible() is deprecated
  • Applied PR by gh pr checkout 46310 and running composer i
    • ❌ There are still 53 ReflectionMethod::setAccessible() is deprecated - With regard to the test instructions, this causes the test to fail.
      • Remaining places are
        administrator/components/com_scheduler/src/Traits/TaskPluginTrait.php
        tests/Unit/Libraries/Cms/Feed/FeedFactoryTest.php
        tests/Unit/Libraries/Cms/Feed/Parser/AtomParserTest.php
        tests/Unit/Libraries/Cms/Feed/Parser/RssParserTest.php
        tests/Unit/Libraries/Cms/Microdata/MicrodataTest.php
        tests/Unit/Libraries/Cms/Updater/ConstraintCheckerTest.php
        tests/Unit/Libraries/Cms/Updater/TufAdapterTest.php
        
    • ℹ️ And there are another 24 different deprecations
      This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46310.

@wojsmol
Copy link
Contributor

wojsmol commented Oct 17, 2025

@muhme Remaining deprecation should be fixed after 5.4-dev upmerge - fixed in #46202

@richard67
Copy link
Member Author

Thanks, I've updated the testing instructions.

@muhme
Copy link
Contributor

muhme commented Oct 19, 2025

I have tested this item ✅ successfully on fa47705

Retested after changed test description with JBT, PHP 8.5.0RC2

  • Before the PR seen 23 ReflectionMethod::setAccessible() is deprecated from libraries/vendor/joomla/test/src/TestHelper.php
  • Applied PR by gh pr checkout 46310 and running composer i
  • ✅ No more ReflectionMethod::setAccessible() is deprecated from libraries/vendor/joomla/test/src/TestHelper.php file
  • ℹ️ There are still 77 deprecation messages, including 53 ReflectionMethod::setAccessible()
    This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46310.

@heelc29
Copy link
Contributor

heelc29 commented Nov 5, 2025

I have tested this item ✅ successfully on fa47705


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46310.

@richard67
Copy link
Member Author

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46310.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 5, 2025
@Bodge-IT Bodge-IT added this to the Joomla! 6.0.1 milestone Nov 10, 2025
@Bodge-IT Bodge-IT merged commit 089a9d3 into joomla:6.0-dev Nov 10, 2025
42 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 10, 2025
@Bodge-IT
Copy link
Contributor

Thanks @richard67 last one done and thanks to @heelc29 & @muhme for comprehensive tests

@richard67 richard67 deleted the 6.0-dev-composer-update-joomla-test-4.0.1 branch November 10, 2025 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants