-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[5.4] - Prepend root url to schema images #46306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 5.4-dev
Are you sure you want to change the base?
Conversation
|
@travisrisner Append? Or did you mean prepend? Append means to add to the end, prepend to the beginning. |
Co-authored-by: Richard Fath <[email protected]>
Good catch, yes prepend! |
|
I have tested this item ✅ successfully on cd0c8e2 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46306. |
|
I have tested this item ✅ successfully on cd0c8e2 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46306. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46306. |
|
@travisrisner I tested this PR before merge and see article's Is it possible to fix Organisation/Person Image absolute URL too? |
Pull Request for Issue #46191 & #43955 .
Summary of Changes
Ensures the root domain is appended to image paths for schema images.
Testing Instructions
Actual result BEFORE applying this Pull Request
The images set by schema did not have the root domain prepended and contained extra metadata from joomla about image sizes.
Expected result AFTER applying this Pull Request
The root domain is prepended and the extra information is removed.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed