Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"PR-staging" removed after set "Easy Test" on "Yes" #962

Closed
ghost opened this issue Apr 22, 2017 · 9 comments
Closed

"PR-staging" removed after set "Easy Test" on "Yes" #962

ghost opened this issue Apr 22, 2017 · 9 comments
Labels

Comments

@ghost
Copy link

ghost commented Apr 22, 2017

Steps to reproduce the issue

Set "Easy Test" on "Yes" at #15464 on Issue Tracker, at Github "PR-staging" is removed

@zero-24
Copy link
Contributor

zero-24 commented Apr 22, 2017

@mbabker could it be that the pull update event is triggerd without files / branch etc. data?

@mbabker
Copy link
Contributor

mbabker commented Apr 22, 2017

Even if that happens the code shouldn't be removing already set labels arbitrarily. So there's a bug in that workflow if labels are getting removed because there's no data.

@zero-24
Copy link
Contributor

zero-24 commented Apr 22, 2017

I'm going to check that. Thanks!

@zero-24
Copy link
Contributor

zero-24 commented Apr 22, 2017

#963 Would be the PR for that. Let's try if that fixes the issue :)

@b2z
Copy link
Member

b2z commented Sep 8, 2017

#963 fixed it?

@ghost
Copy link
Author

ghost commented Sep 8, 2017

Same behaviour, test on #17896: Set "Easy Test" on "Yes" removes Label "PR-staging".

@ghost
Copy link
Author

ghost commented Nov 20, 2017

@b2z can this Issue become also a "Bug"-Label like #994?

@b2z b2z added the bug label Nov 22, 2017
@b2z
Copy link
Member

b2z commented Nov 22, 2017

@franz-wohlkoenig sure :)

@ghost
Copy link
Author

ghost commented Aug 29, 2018

closed as duplicate Report #947

@ghost ghost closed this as completed Aug 29, 2018
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants