Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swap solid and default header layout roles #18

Open
shoulders opened this issue Oct 7, 2019 · 1 comment
Open

swap solid and default header layout roles #18

shoulders opened this issue Oct 7, 2019 · 1 comment

Comments

@shoulders
Copy link

shoulders commented Oct 7, 2019

NB: this might just be the way I do things

when i first used JD seattle (from scratch) I found it hard to workout why the content was always pushed up. It was becasue the default layout has the header with the absolute posistioning and the whole layout relies on there being content published to the slider or banner area.

When end uses start to use components which are not specified via menu areas or have content in the areas specified they will find their content shoved up underneath the menu and might not figure out why.

My solution is easy.

  1. set the solid header as the default template/layout. The website will behave as normal and as people expect.
  2. set the current menu items to specify the use of the 'modified header' layout. This also show the user/developer that some non-standard styling has been done and where to look.
@Nishtha003
Copy link

You are right! We also thought of doing this the right way, therefore we have already implemented your first solution when you try to install the Template Only file there we have the solid header as the default template & if anybody wants to make the header transparent they can do that from the Settings file.

And as far as the second solution is concerned, we can make that as one of the menu items & keep solid as the default. Will work on this in the coming update hopefully!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants