Skip to content

Commit b98b962

Browse files
committed
logback: remove static logger from Jooby class
1 parent 59ea88c commit b98b962

2 files changed

Lines changed: 22 additions & 1 deletion

File tree

jooby/src/main/java/io/jooby/Jooby.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ public class Jooby implements Router, Registry {
6767
static final String APP_NAME = "___app_name__";
6868

6969
private static final String JOOBY_RUN_HOOK = "___jooby_run_hook__";
70-
private static final Logger log = LoggerFactory.getLogger(Jooby.class);
70+
private final Logger log = LoggerFactory.getLogger(Jooby.class);
7171

7272
private final transient AtomicBoolean started = new AtomicBoolean(true);
7373

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
/*
2+
* Jooby https://jooby.io
3+
* Apache License Version 2.0 https://jooby.io/LICENSE.txt
4+
* Copyright 2014 Edgar Espina
5+
*/
6+
package io.jooby;
7+
8+
import static org.junit.jupiter.api.Assertions.assertFalse;
9+
10+
import java.lang.reflect.Modifier;
11+
12+
import org.junit.jupiter.api.Test;
13+
14+
public class Issue3963 {
15+
16+
@Test
17+
void logVariableCannotBeStatic() throws NoSuchFieldException {
18+
var field = Jooby.class.getDeclaredField("log");
19+
assertFalse(Modifier.isStatic(field.getModifiers()));
20+
}
21+
}

0 commit comments

Comments
 (0)