Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitespace Characters #34

Open
wbw20 opened this issue Jan 30, 2015 · 6 comments
Open

Whitespace Characters #34

wbw20 opened this issue Jan 30, 2015 · 6 comments

Comments

@wbw20
Copy link

wbw20 commented Jan 30, 2015

Hello

Great project. Have you guys ever considered an option for displaying whitespace characters in the match results? Kind of like Sublime Text does?

screen shot 2015-01-30 at 11 51 47 am

Maybe it could be a toggle option or something? Just a thought. If there is interest I can work on a PR.

@jonmagic
Copy link
Owner

I'd never thought of it, seems like an interesting idea though. Can you give an example of where it would be helpful when building a regular expression?

@wbw20
Copy link
Author

wbw20 commented Feb 2, 2015

When you are matching whitespace characters it is difficult to see exactly what the capture groups have in them. Maybe this isn't a problem for most people but it is something I was trying to do.

@jonmagic
Copy link
Owner

jonmagic commented Feb 3, 2015

Makes sense to me 👍 I think this would be a good feature for the tool, I'd love to see a pull request ✨

Not this week, but next week I would probably have some time to pair program too if you were interested in pairing on it at all (I usually use Screenhero, but it looks like they have been acquired and don't allow new signups).

@wbw20
Copy link
Author

wbw20 commented Feb 18, 2015

Hey Jon,

I had a little extra time today so I threw together a prototype. Let me know if you like the direction it is going. ✌️

wbw20/scriptular@wbw20:master...show_whitespace_chars

screen shot 2015-02-17 at 5 26 55 pm

@jonmagic
Copy link
Owner

@wbw20 I dig it 👍 Looks good and conveys valuable information.

@jonmagic
Copy link
Owner

Any interest in opening a PR with your changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants