Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AIN signal to DAC output mapping inconsistent between brake, throttle and steering modules #6

Open
jonlamb-gh opened this issue Aug 20, 2018 · 1 comment
Open

AIN signal to DAC output mapping inconsistent between brake, throttle and steering modules #6

jonlamb-gh opened this issue Aug 20, 2018 · 1 comment
Labels
porting concern Concern originating from the OSCC source code port

Comments

@jonlamb-gh
Copy link
Owner

jonlamb-gh commented Aug 20, 2018 •
edited

All of the modules should have a consistent mapping between the analog input hight/low signals and the DAC output A/B channels.

I think the mapping should be:

  • AIN signal high maps to DAC channel A
  • AIN signal low maps to DAC channel B

Currently the brake and throttle modules are inverting the mapping when they
call the prevent_signal_discontinuity() function.

The steering module seems to be using them correctly.

TODO Confirm this is a bug in the OSCC firmware or just a hardware pin mapping issue.

Can we do away with high/low and just have A/B for both input and output?
@jonlamb-gh
Copy link
Owner Author

jonlamb-gh commented Aug 20, 2018 •
edited

Some discussion in these:

@jonlamb-gh jonlamb-gh added the porting concern Concern originating from the OSCC source code port label Oct 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
porting concern Concern originating from the OSCC source code port
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jonlamb-gh