Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should control command timeouts be re-implemented? #13

Open
jonlamb-gh opened this issue Aug 21, 2018 · 0 comments
Open

Should control command timeouts be re-implemented? #13

jonlamb-gh opened this issue Aug 21, 2018 · 0 comments
Labels
enhancement New feature or request

Comments

@jonlamb-gh
Copy link
Owner

Some discussion on OSCC control command timeouts in this PR; they were removed.

Is that a reasonable claim? What happens when the last throttle command was non-zero and no further control commands (or any CAN frames) are received?

We have plenty of cycles to burn, and it would be pretty easy to re-implement that logic.
@jonlamb-gh jonlamb-gh added the enhancement New feature or request label Oct 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jonlamb-gh