-
Notifications
You must be signed in to change notification settings - Fork 28
Add support for localizations #30
Comments
I'd be happy to work on German. |
Could you link the english localisation file so we can PR it? |
@neauoire yup, will add it to develop soon. I'd like to support all options for contribution especially for those who aren't comfortable in committing files/making a PR. |
Sounds good I'll try to do french & Lietal |
I can help with Arabic translation. |
@neauoire you can now find the strings under @maroun-baydoun I haven't tested RTL yet, but getting all of the strings for such languages is the starting place. I'm honestly expecting some of the UI to break for other languages too, but therein lies the challenge to fix things. 😆 Once strings are in I will make sure they wont ship without RTL support. Unless you'd like to give it a go. @harleo ready for your help! |
@jonathontoon Done. #115 |
@maroun-baydoun any interest still in doing Arabic? |
@jonathontoon Yes, I will do it and send a PR. |
Ja related issue: #194 |
Going to use react-localization. Even though Twitter accounts have a language setting which comes down from the API I think basing the locale off what the computer is using will be the way to go. Will avoid allowing a user to customize their language for now.
Below is a list of all the custom strings supported by Tweet Tray (which cannot already be sourced from Twitter's apps), and a list of which languages require localization.
If you would like to contribute, you can submit a pull request (following these (guidelines)[https://github.com/jonathontoon/tweet-tray#development]) for strings per language found under
app/localizations
. If the there is not a file for your language (e.g:en-US.json
) you can create it as part of the pull request.The text was updated successfully, but these errors were encountered: