Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

errors in Example code? #2

Open
tnovotny opened this issue Nov 13, 2017 · 1 comment
Open

errors in Example code? #2

tnovotny opened this issue Nov 13, 2017 · 1 comment
Assignees
@jonathan-beard

Comments

@tnovotny
Copy link

tnovotny commented Nov 13, 2017 •
edited
Loading

In the Example

  1. it looks like func_b should be doing a pop and not push.
  2. there is a race condition on term. That's UB, so it should probably be something like an atomic<bool>.
@jonathan-beard
Copy link
Owner

Thanks! I'll take a look this weekend.

@jonathan-beard jonathan-beard self-assigned this Dec 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonathan-beard jonathan-beard

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonathan-beard @tnovotny