Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark/light mode should have a color overlay on background to match material elevation #244

Open
0xakihiko opened this issue Apr 15, 2023 · 2 comments

Comments

@0xakihiko
Copy link

Great plugin.

I would like to suggest a color overlay that more closely match the material design, which is to add an overlay that makes the background brighter or darker as the elevation increases based on the variant.

Seen here: https://m3.material.io/styles/elevation/overview
One thing to note is that while it's not listed here, it is my understanding that in material 2 this would result in a lighter overlay for dark modes.

@jonaskay
Copy link
Owner

Thank you writing the issue! I'm gonna look into this more in a couple of weeks. Just to be clear, the two issues are:

  1. Unlike M2, M3 doesn't apply shadows by default to all levels of elevation and instead uses color to achieve the elevation effect.
  2. Even when using shadows (the M2 way), the plugin needs to support different box shadows when switching between dark and light modes.

@0xakihiko
Copy link
Author

0xakihiko commented May 3, 2023

Yep, that's correct.

M3 can still apply shadow(although, optional), but it's to differentiate elevations if they have similar color (I believe?).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants