Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qualifying/Sprint Endpoint: "fastest" and "status" filter return no data when used #9

Open
theOehrly opened this issue Mar 6, 2024 · 3 comments · Fixed by #27
Open
Labels
bug Something isn't working ergast parity Difference from ergast API that isn't data related

Comments

@theOehrly
Copy link
Collaborator

When using the "fastest" or "status" filter in combination with the /qualifying endpoint, no data at all is returned.

These filters work with data from the race results (fastest lap in the race and finishing status in the race respectively).

Example:
http://api.jolpi.ca/ergast/f1/2023/fastest/1/qualifying.json
http://ergast.com/api/f1/2023/fastest/1/qualifying.json

I have to say that this is a rather unusual way to filter the qualifying results. Therefore, if this is difficult to fix, I'd vote in favour of not supporting these filters on this endpoint.

@theOehrly theOehrly added the bug Something isn't working label Mar 6, 2024
@theOehrly theOehrly added this to the JSON Endpoints milestone Mar 7, 2024
@jolpica jolpica added the ergast parity Difference from ergast API that isn't data related label Mar 14, 2024
jolpica added a commit that referenced this issue Mar 24, 2024
jolpica added a commit that referenced this issue Mar 24, 2024
@theOehrly
Copy link
Collaborator Author

@theOehrly theOehrly reopened this Apr 3, 2024
@theOehrly theOehrly changed the title Qualifying Endpoint: "fastest" and "status" filter return no data when used Qualifying/Sprint Endpoint: "fastest" and "status" filter return no data when used Apr 3, 2024
jolpica added a commit that referenced this issue Apr 6, 2024
jolpica added a commit that referenced this issue Apr 6, 2024
jolpica added a commit that referenced this issue Apr 6, 2024
jolpica added a commit that referenced this issue Apr 6, 2024
jolpica added a commit that referenced this issue Apr 6, 2024
jolpica added a commit that referenced this issue Apr 6, 2024
@theOehrly
Copy link
Collaborator Author

Sorry to reopen again, but this is still problematic. The problem is not quite the same but very related, therefore I'll reuse this issue.

Some definitions first, for clarification, because these filters can be a bit confusing.

  1. /2023/qualifying/<n>.json
    This filter combination returns all results where a driver finished qualifying in the nth position.

  2. /2023/grid/<n>/qualifying.json
    This filter combination returns all qualifying results where a driver had the _nth> starting grid position. This differs from (1) in case of grid drops.

  3. /2023/fastest/<n>/qualifying.json
    This filter combination returns all qualifying results where a driver subsequently set the nth fastest lap in the race.

All of these filters work fine on their own, but some of them don't work in combination. What is currently not working is

  • http://api.jolpi.ca/ergast/f1/2023/fastest/1/qualifying/1.json and similar, i. e. combining fastest lap in race with qualifying finishing position
  • http://api.jolpi.ca/ergast/f1/2023/status/1/qualifying/1.json and similar, i. e. combining race finishing status with qualifying finishing position

All other combinations work fine.

@theOehrly theOehrly reopened this May 22, 2024
@theOehrly
Copy link
Collaborator Author

Also noting #10 that is fixed but related

@jolpica jolpica closed this as completed in 5b89477 Aug 5, 2024
jolpica pushed a commit that referenced this issue Aug 5, 2024
jolpica pushed a commit that referenced this issue Aug 5, 2024
jolpica pushed a commit that referenced this issue Aug 5, 2024
jolpica added a commit that referenced this issue Aug 6, 2024
jolpica added a commit that referenced this issue Aug 6, 2024
jolpica added a commit that referenced this issue Aug 6, 2024
jolpica added a commit that referenced this issue Aug 6, 2024
@jolpica jolpica reopened this Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ergast parity Difference from ergast API that isn't data related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants