Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve internal cache of requests #46

Open
jolpica opened this issue May 21, 2024 · 0 comments
Open

Improve internal cache of requests #46

jolpica opened this issue May 21, 2024 · 0 comments

Comments

@jolpica
Copy link
Owner

jolpica commented May 21, 2024

Currently page cache is done via the cache_page decorator.

However this caches the entire page, and results in separate caches for different formats (e.g. html and json).
Instead the cache should be made on the output of the serializer's to_representation method.

This has the following benefits:

  • More reuse of the cache
  • Currently when the cache is hit, it does not count towards rate limiting. Which we may not be what we want.
@jolpica jolpica changed the title Improve internal cacheing of requests Improve internal cache of requests May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant