Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session form - General behaviour #193

Open
LolaRev opened this issue Oct 29, 2020 · 4 comments
Open

Session form - General behaviour #193

LolaRev opened this issue Oct 29, 2020 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@LolaRev
Copy link
Collaborator

LolaRev commented Oct 29, 2020

I collected some comments regarding the session form:

  1. The # of session field - we should have the option not to add a number in case it is an ongoing thing. My recommendation is to add a comment "Please leave empty if it is an ongoing session" and make the field mandatory.
    image

  2. The special offer field - this is the text that should be presented here. if it is not added then the blue banner should not be presented.
    image
    Also, please change the text in the field to "e.g. 10% off"
    image

  3. Related sessions - should be limited to 3 and links.
    image

  4. Activity - Should be multiselection - up to 3.
    image

  5. Price - Some of the sessions are going to be for free. I think, in order to avoid mistakes, it will be wise to ask the teacher to choose f it is a free or paid session + specifying the price for paid.
    @yinonov for the free sessions, we want to add a donation button - pay-as-you-can. so that if a student wants to contribute to the teachers they can do it. I am not sure if it is complicated stuff, I can open a new ticket for that, for enhancement. LMK please.

@LolaRev LolaRev added the bug Something isn't working label Oct 29, 2020
@LolaRev LolaRev added this to the Bring Joie web app to Life milestone Oct 29, 2020
@yinonov
Copy link
Collaborator

yinonov commented Oct 31, 2020

  • 1 @LolaRev how can we set this a mandatory field while allowing it to be empty? p.s. draft sessions are kind of "loose" and wont be as strict as once publish. so at this point we shouldn't harden session that much. keeping incremental strictness to a later issue. added the hint for now
  • 2
  • 3 @LolaRev are these url links?
  • 4
  • 5 @LolaRev yes, it's bigger than a bug fix, let's open an enhance issue

@yinonov
Copy link
Collaborator

yinonov commented Nov 1, 2020

@LolaRev should the related sessions list be an existing sessions of the same teacher? maybe we better display a data list (autocomplete) of the session? why should the urls be manually typed?

@LolaRev
Copy link
Collaborator Author

LolaRev commented Nov 1, 2020

  • 1 @LolaRev how can we set this a mandatory field while allowing it to be empty? p.s. draft sessions are kind of "loose" and wont be as strict as once publish. so at this point we shouldn't harden session that much. keeping incremental strictness to a later issue. added the hint for now
  • 2
  • 3 @LolaRev are these url links?
  • 4
  • 5 @LolaRev yes, it's bigger than a bug fix, let's open an enhance issue
  1. Sorry, I ment not mandatory. If you have a better solution please let me know.
  2. They are links to other sessions the teachers created. The easiest way will be to have their session list as a drop down menu but it might be complicated for us at this point.
  3. Ok

@LolaRev
Copy link
Collaborator Author

LolaRev commented Nov 1, 2020

@LolaRev should the related sessions list be an existing sessions of the same teacher? maybe we better display a data list (autocomplete) of the session? why should the urls be manually typed?

That would be great. I just didn't want to complicate things for you. If they can choose, auto complete the name of the session, that's great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants