Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session page specification #135

Closed
yinonov opened this issue Oct 3, 2020 · 3 comments
Closed

Session page specification #135

yinonov opened this issue Oct 3, 2020 · 3 comments
Labels
refactor restructuring an existing body of code, altering its internal structure without changing its externa Styling Style related issue

Comments

@yinonov
Copy link
Collaborator

yinonov commented Oct 3, 2020

Session page isn't coded as expected. it needs to be refactored to align with the following:

Main

  • header with values of pillar, title, owner.
  • metadata prefixed with joie icons (@yinonov need to be enhanced to include the specified icons and size Joie Icons - extend #134)
  • thumbnail / intro video - own component to be used here and in sessions list. if no thumb or intro show different component for upload management (not part of this issue context)
  • tabs (encapsulated in individual components)
    • What you will learn - information extracted from session document (parts can still be missing in document)
    • Meet your teacher - lazy loaded content fetched from session owner's document
    • What our community say - missing specification, leave empty
  • recommended sessions - outside of this issue scope

Aside

  • session list should be queried to display relevant context (query is an exposed input for session list) @LolaRev would you please define the added data to query this. might be a totally different collection of campaign / sales that refers a session document

Note:

Use only existing tools at our possession. any missing components or features should be issued in other context.

@yinonov yinonov added Styling Style related issue refactor restructuring an existing body of code, altering its internal structure without changing its externa labels Oct 3, 2020
@yinonov yinonov added this to the Bring Joie web app to Life milestone Oct 3, 2020
@yinonov yinonov linked a pull request Oct 3, 2020 that will close this issue
@yinonov yinonov pinned this issue Oct 3, 2020
@LolaRev
Copy link
Collaborator

LolaRev commented Oct 3, 2020

@yinonov sorry, I am not sure I understand what is needed from me here. Care to elaborate?

@yinonov
Copy link
Collaborator Author

yinonov commented Oct 3, 2020

@widesea30 correction regarding aside part -
the session shown is of the same document. it's a sticky banner that should always appear while scrolling, an engaging floating banner to allow easy enrolment of the session.
conditionally show

  1. enrol button if viewer hasn't enrolled
  2. "you are enrolled" if user has enrolled

if is owner don't show any of the 2 👆

@LolaRev
Copy link
Collaborator

LolaRev commented Oct 7, 2020

@widesea30 @yinonov
My comments:

  1. Pillar - please add the pillar icon next to the pillar name
    image
    Same in the card:
    image

  2. Small icons don't need the blue background behind them.
    Code:
    image
    Design:
    image

  3. Some of the small icons and information is missing: 1. Date+time. 2. Duration. 3. I am missing the share icon.
    image

  4. Same here:
    image

  5. Styling of the fonts: colours, alignment, sizes, and spaces should be adjusted as in the design.

  6. Remove this part for now.
    image

  7. Information is missing from the page:
    image
    a. small icons (no background)
    b. activity
    c. should be singular and not plural - session, Pillar
    d. Goals
    e. Need to know
    f. Contact the teacher (@yinonov you asked to move it to the teacher tab, right?)

  8. Meet the teacher - should be the teacher's bio + contact

  9. What our community say tab - should be the reviews (see teacher's page for the design).

  10. Below the 3 sessions - missing a link to the sessions search page:
    image

  11. Below the button - if a session doesn't have reviews yet, the message should say "No reviews yet"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor restructuring an existing body of code, altering its internal structure without changing its externa Styling Style related issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants