Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not compatible with jquery 3.3.0+ #291

Open
bitno2u opened this issue May 25, 2023 · 6 comments
Open

Not compatible with jquery 3.3.0+ #291

bitno2u opened this issue May 25, 2023 · 6 comments

Comments

@bitno2u
Copy link

bitno2u commented May 25, 2023

Draggable list elements only can be put at the bottom of the list. They can not be dragged inside any connected lists placed on right, bellow or diagonally. Can you fix this?

@bitno2u bitno2u changed the title Not compatible with jquery 3.3.1+ Not compatible with jquery 3.3.0+ May 25, 2023
@bitno2u
Copy link
Author

bitno2u commented May 26, 2023

Ad-hoc solution: Change jquery 3.3.x file
instead
(offsetParent === doc.body || offsetParent === doc.documentElement) &&
insert
(offsetParent !== doc && offsetParent !== doc.body && offsetParent !== doc.documentElement) &&

For morde details look jquery/jquery@5e7e4d7#diff-62d55137fbe4b552f5a996d0af19023a42aeed89686647e7b4e4026fd1a66186

@bitno2u
Copy link
Author

bitno2u commented May 26, 2023

Better solution: Change jquery-sortable.js

instead
if (el.css("position") === "relative" || el.css("position") === "absolute" || el.css("position") === "fixed")
insert
if (el.css("position") === "relative" || el.css("position") === "absolute" || el.css("position") === "fixed" || el.css("position") === "static")

@venkatt05
Copy link

@bitno2u They can not be dragged inside any connected lists placed on right, bellow or diagonally - I was trying to replicate this issue with my project but couldn't do it. Could you please help with some more detail.

@bitno2u
Copy link
Author

bitno2u commented Oct 12, 2023

Download jquery-sortable.js v0.9.13 and add "static" as an option for el.css("position"), as described before.

@venkatt05
Copy link

Yes, I got that part. I wanted to reproduce the issue in my system. I was using the 0.9.13 and jQuery 3.3.1, but I can't able to replicate the issue reported here. Is this issue happening is any specific scenario ?

@ryanb
Copy link

ryanb commented Oct 31, 2023

I ran into this issue as well. For me it only affects sorting within tables. I tried adding el.css("position") === "static" as recommended above which does help, but there's still considerable offset on the sorting. I ended up changing the table to divs to work around this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants