Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect jquery dependency version specification. #262

Open
ericwooley opened this issue Mar 6, 2019 · 0 comments
Open

Incorrect jquery dependency version specification. #262

ericwooley opened this issue Mar 6, 2019 · 0 comments

Comments

@ericwooley
Copy link

ericwooley commented Mar 6, 2019 •
edited
Loading

https://docs.npmjs.com/misc/semver#ranges and https://yarnpkg.com/lang/en/docs/dependency-versions/#toc-unions specify the version should use a> or >= syntax not a ^.

Currently jquery-sortable uses

jquery-sortable/package.json

Line 29 in 4d31eea

"jquery": "^2.1.2 || ^3.0.0"

The way it is setup now, causes yarn to install jquery 2.x when jquery 3 is a top level dependency
ericwooley pushed a commit to ericwooley/jquery-sortable that referenced this issue Mar 7, 2019
correct range, fixes johnny#262
5360005
ericwooley pushed a commit to ericwooley/jquery-sortable that referenced this issue Mar 7, 2019
correct range, fixes johnny#262
356520d
@ericwooley ericwooley mentioned this issue Mar 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

correct jQuery dependency range, closes #262 ericwooley/jquery-sortable
1 participant
@ericwooley