Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document + maybe add some flexibility for powerspectrum convention #17

Open
johnh2o2 opened this issue Jun 5, 2022 · 0 comments
Open

Comments

@johnh2o2
Copy link
Owner

johnh2o2 commented Jun 5, 2022

Our BLS implementation returns only one type of bls "power" = the square of the "signal residue" from https://arxiv.org/abs/astro-ph/0206099.

The astropy BLS implementations give additional conventions for the "power": https://docs.astropy.org/en/stable/timeseries/bls.html. We should (1) be very clear about what exactly we are calculating and returning so that we avoid confusion, and (2) if possible, allow user to specify which convention they want to have returned.

I believe the same is also true for Lomb Scargle -- we're only returning a single convention. In LS we are clear in the documentation about what convention we are using but it might be good to allow alternatives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant