_load_textdomain_just_in_time was called incorrectly

[f14m07]

Hi,
I have this message in my php error log since the last WP 6.7 update.
To see this error your site must be in a foreign language and you must have debug mode.

Notice: Function _load_textdomain_just_in_time was called incorrectly. Translation loading for the query-monitor domain was triggered too early. This is usually an indicator for some code in the plugin or theme running too early. Translations should be loaded at the init action or later. Please see Debugging in WordPress for more information. (This message was added in version 6.7.0.) in /Users/xxxx/Local Sites/clone-reve/app/public/wp-includes/functions.php on line 6114

This isn't the only plugin to have this problem.
You must be in debug mode and with a foreign lang site to reproduce this notice.
Could you update your code please ?

Thanks for all.

Have a nice day.

Frédéric

[johnbillion]

Thanks for the report. I've already been looking into a fix for this. It's ironically caused by the "Doing it wrong" handler in Query Monitor which gets triggered when another plugin loads a translation too early.

[f14m07]

It's true because having deactivated the other plugins that have the same error, I no longer get the query monitor error. Thanks for your quick response

[johnbillion]

@f14m07 Are you still seeing this problem with WordPress 6.7.1?

[f14m07]

No it's Ok Not new issue.

[cbratschi]

Still getting this error in WordPress 6.7.1:

[06-Dec-2024 16:46:04 UTC] PHP Notice: Function _load_textdomain_just_in_time was called incorrectly. Translation loading for the query-monitor domain was triggered too early. This is usually an indicator for some code in the plugin or theme running too early. Translations should be loaded at the init action or later. Please see Debugging in WordPress for more information. (This message was added in version 6.7.0.) in /home/site/wp-includes/functions.php on line 6114

[felipeelia]

I'm seeing this problem in a different context now. ElasticPress makes a remote HTTP call using wp_remote_post() and as Query Monitor monitors all those, QM itself is calling __() earlier than expected here. I'm still debugging it but wanted to share this finding asap, so hopefully it helps. Also worth noting I'm having a hard time reproducing all these problems, as the notice will not be displayed unless I delete all transients using wp transient delete --all.

[johnbillion]

Thanks. This seems like a never ending problem once you dig into it.

I'll need to do some work to shift all the translation strings out of the collectors and into the output.

[afragen]

Just documenting a conversation with John. I was seeing similar errors and think it may be do to a response from wp_remote_get() returning something that QM is trying to translate from doing_it_wrong. I believe the following lines from my log are the inciting translations from QM.

[18-Dec-2024 20:04:58 UTC] PHP  17. __($text = 'Plugin: %s', $domain = 'query-monitor') /Users/afragen/Local_Sites/lightning/app/public/wp-content/plugins/query-monitor/classes/Util.php:200
[18-Dec-2024 20:04:58 UTC] PHP  18. translate($text = 'Plugin: %s', $domain = 'query-monitor') /

[18-Dec-2024 20:04:58 UTC] PHP  37. __($text = 'WordPress Core', $domain = 'query-monitor') /Users/afragen/Local_Sites/lightning/app/public/wp-content/plugins/query-monitor/classes/Util.php:246
[18-Dec-2024 20:04:58 UTC] PHP  38. translate($text = 'WordPress Core', $domain = 'query-monitor') /

What a PITA this change has been. Silently failing seems to be so much better.

[afragen]

Got tired of seeing this and with some help from John (thanks John) I give you.

https://gist.github.com/afragen/986ba6046ebea963074283a77cae07fc

[kagg-design]

It can be temporarily fixed by #940.