Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: mermaid diagram rendering #355

Open
patricksurry opened this issue Feb 16, 2022 · 2 comments · May be fixed by #389
Open

Feature request: mermaid diagram rendering #355

patricksurry opened this issue Feb 16, 2022 · 2 comments · May be fixed by #389

Comments

@patricksurry
Copy link

Presumably a limitation of the /markdown api but grip doesn't render the newly supported mermaid diagrams in markdown. Hoping that gets added at some point 🤞
@solomspd
Copy link

solomspd commented Sep 4, 2022

I've been poking around this issue, I think a way to conveniently view mermaid diagrams in markdown is great.
For anyone wondering, turns out this is explicitly disabled by GitHub

"clients requesting content with embedded Mermaid in a non-JavaScript environment (such as an API request) will see the original Markdown code"

And there does not seem to be a way around this in the API docs

Here's hoping this will be implemented in the grip offline renderer

@wwalker
Copy link

wwalker commented Oct 15, 2023

It seems that one could have grip call mermaid-cli to generate an svg and include that via a simple <img src....

@nikolavp nikolavp linked a pull request Jul 9, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add mermaid diagrams support through javascript nikolavp/grip
3 participants
@wwalker @patricksurry @solomspd