New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Name collision with "require" #9

Open

JonathanWheeler opened this issue Feb 21, 2015 · 2 comments

JonathanWheeler commented Feb 21, 2015

filtrex has a global name collision with requirejs's require. Can we please rename all references to require?

JonathanWheeler changed the title Name collision on **require** Name collision with "require"

Owner

joewalnes commented Feb 21, 2015

This is actually an issue in the jison.js dependency.

A few options:

As part of the build file we find and replace all "require" refs to something else, e.g. "_internal_filterex_require".
We wrap everything in an anonymous function (function() { ... })() so it doesn't pollute the global namespace.

@JonathanWheeler: I'm busy with other projects right now. Want to take a crack at either of these?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment