Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"fixthis" is an ambiguous function name #1

Open
jbccollins opened this issue Aug 9, 2018 · 2 comments
Open

"fixthis" is an ambiguous function name #1

jbccollins opened this issue Aug 9, 2018 · 2 comments

Comments

@jbccollins
Copy link

The README on "fixthis":

Prevents the rebinding of this

The name of that function in no way indicates what it actually does.
How about "lockthis" or "freezethis" or something similar?
@joelnet
Copy link
Owner

joelnet commented Aug 9, 2018

Naming is my kryptonite. I will spend 30 minutes on a character creating screen trying to figure out that I should call the avatar.

These names are good suggestions.

@styfle
Copy link

styfle commented Aug 14, 2018

The nothisAll is not intuitive to me.
Consider using fixThisClass since it's meant to be used in the constructor of a class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@styfle @joelnet @jbccollins