Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chapter transition page sometimes disappears without user input #1250

Closed
6 tasks done
perokhe opened this issue Aug 16, 2024 · 3 comments
Closed
6 tasks done

Chapter transition page sometimes disappears without user input #1250

perokhe opened this issue Aug 16, 2024 · 3 comments
Labels
Bug Something isn't working

Comments

@perokhe
Copy link

perokhe commented Aug 16, 2024

Steps to reproduce

  1. Have "Always show chapter transition" enabled
  2. Open a chapter and scroll to previous chapters

Expected behavior

The chapter transition page should show until I scroll again

Actual behavior

The page disappears without user input and goes to previous/next chapter

Crash logs

No response

TachiyomiSY version

Preview r562

Android version

Android 10

Device

Samsung Note 9

Other details

TachiyomiSY.mp4

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
  • I have written a short but informative title.
  • I have gone through the FAQ and troubleshooting guide.
  • I have updated the app to version 1.10.5.
  • I have updated all installed extensions.
  • I will fill out all of the requested information in this form.
@perokhe perokhe added the Bug Something isn't working label Aug 16, 2024
@Smol-Ame
Copy link

Smol-Ame commented Aug 17, 2024

(For Syer) I reverted the codestral cleanup of some double pages code to test & the issue seems partly fixed. Reverting made it no longer jump to the last page of the previous chapter (stays on Chapter Transition), but still displays a loading page text/loading circle overlay. (Hopefully that helps you out :amepray:)

@perokhe
Copy link
Author

perokhe commented Sep 22, 2024

Yeah, more specifically I think the problem is that the line if (newPage is ChapterTransition && index == -1) was changed to just is ChapterTransition -> {
1a4a250#diff-1e09718bb3bc7e66c42f70eda465d2834556a72c070a57c5de104ca01e74c8c5L360

jobobby04 pushed a commit that referenced this issue Oct 14, 2024
Co-authored-by: AntsyLich <[email protected]>
(cherry picked from commit 6b2bba4)
@perokhe
Copy link
Author

perokhe commented Dec 19, 2024

Fixed with de6cd16

@perokhe perokhe closed this as completed Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants