Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethink of project logic #8

Open
joshbenaron opened this issue May 31, 2021 · 3 comments
Open

Rethink of project logic #8

joshbenaron opened this issue May 31, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@joshbenaron
Copy link

joshbenaron commented May 31, 2021

Hey,
I was just starting to implement the SELECT query of the engine and I guess I've been thinking about the overall approach. At the moment it seems to be very modular (which isn't actually bad when it comes to abstracting over the engine). Parse query -> Parse to structs -> Execute. I think we should remove the middle step and go straight to execution. This would mean fewer allocations along the line. So basically take sqlparser's output and just use that in execution
I'd love to know what you think.

@joshbenaron joshbenaron changed the title Rethink of project structure Rethink of project logic May 31, 2021
@joaoh82 joaoh82 added the enhancement New feature or request label Jun 14, 2021
@joaoh82
Copy link
Owner

joaoh82 commented Jun 14, 2021

I like the idea of having fewer allocations. Definitely decreasing possible failure points.

Btw, I created a discord server for the project so we can start have a more active conversation and build a community. Here is the link: https://discord.gg/zHXUG66X .

@joshbenaron
Copy link
Author

joshbenaron commented Jun 29, 2021

I like the idea of having fewer allocations. Definitely decreasing possible failure points.

Btw, I created a discord server for the project so we can start have a more active conversation and build a community. Here is the link: https://discord.gg/zHXUG66X .

@joaoh82 Hey sorry, I just saw this. Can you send an updated link, please?

@joaoh82
Copy link
Owner

joaoh82 commented Jun 29, 2021

Hi @joshbenaron , here you go.

https://discord.gg/NRtpsvEDyS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants