Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow compilation using -Wall -Werror #574

Open
rursprung opened this issue May 1, 2023 · 0 comments
Open

allow compilation using -Wall -Werror #574

rursprung opened this issue May 1, 2023 · 0 comments

Comments

@rursprung
Copy link

currently the build fails with the following errors when including pigpio.h from a project which uses -Wall -Werror:

In file included from .../foo.cpp:1:
.../pigpio.h:4528:6: error: "/*" within comment [-Werror=comment]
 4528 | /home/* n
      |
.../pigpio.h:4529:22: error: "/*" within comment [-Werror=comment]
 4529 | /home/pi/shared/dir_1/* w
      |
.../pigpio.h:4530:22: error: "/*" within comment [-Werror=comment]
 4530 | /home/pi/shared/dir_2/* r
      |
.../pigpio.h:4531:22: error: "/*" within comment [-Werror=comment]
 4531 | /home/pi/shared/dir_3/* u
      |
.../pigpio.h:4584:11: error: "/*" within comment [-Werror=comment]
 4584 |    // /ram/*.c r
      |
.../pigpio.h:4740:11: error: "/*" within comment [-Werror=comment]
 4740 |    // /ram/*.c r
      |

it seems that this should be fairly simple to fix (just adapt the comment) but i decided against providing a PR as the comments carry some meaning (they show paths) and i'm not familiar with this code, so i'm unsure what the best replacement would be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant