Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

find_package_handle_standard_args(rt ...) uses wrong case #494

Open
calumr opened this issue Oct 6, 2021 · 0 comments · May be fixed by #495
Open

find_package_handle_standard_args(rt ...) uses wrong case #494

calumr opened this issue Oct 6, 2021 · 0 comments · May be fixed by #495
Labels
PendingPR

Comments

@calumr
Copy link

calumr commented Oct 6, 2021

Right now I get the following warning when using pigpio via cmake:

CMake Warning (dev) at /usr/share/cmake-3.18/Modules/FindPackageHandleStandardArgs.cmake:273 (message):
  The package name passed to `find_package_handle_standard_args` (rt) does
  not match the name of the calling package (RT).  This can lead to problems
  in calling code that expects `find_package` result variables (e.g.,
  `_FOUND`) to follow a certain pattern.
Call Stack (most recent call first):
  /home/calum/bin/_deps/pigpio-src/cmake/FindRT.cmake:28 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
  /home/calum/bin/_deps/pigpio-src/CMakeLists.txt:8 (find_package)
This warning is for project developers.  Use -Wno-dev to suppress it.

The fix is to just use uppercase for the package name:

FIND_PACKAGE_HANDLE_STANDARD_ARGS(RT ...)
@calumr calumr linked a pull request Oct 6, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
PendingPR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix case of RT cmake package calumr/pigpio
2 participants
@calumr @guymcswain