Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make lightning bolts optional #4

Open
kaldari opened this issue Aug 28, 2019 · 3 comments
Open

Make lightning bolts optional #4

kaldari opened this issue Aug 28, 2019 · 3 comments

Comments

@kaldari
Copy link

kaldari commented Aug 28, 2019

I love this project and especially how simple it is to use, so I'm hesitant to make this suggestion, but... there's just no way that I'm actually going to use this if it appends lightning bolts to all the context words. It interferes with the readability too much for my tastes. Is there any chance that the lightning bolts could be made optional (or removed entirely)?

@joakin
Copy link
Owner

joakin commented Aug 30, 2019

This library doesn’t add any styles for the links on the page. Those link styles are added by the content author (in the demos they were added by designers).

For example, Mikhail on his blog styled the links differently https://mpopov.com/wikipedia-context-cards-test/

I think we could have some guidelines for content authors but the library doesn’t impose any styles on the page, only the base styles for the Popup.

@joakin
Copy link
Owner

joakin commented Aug 30, 2019

See

a.wikiPreview {
, where the lightning bolt style is added to the demo content sites.

The JS library itself doesn’t have any style for the links, just for the pop ups.

@kaldari
Copy link
Author

kaldari commented Aug 30, 2019

Oh great! The demos confused me. Maybe some of the demos should omit the lightning bolt so it doesn't seem like it's something hard-coded into the software.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants