New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate Feature "id" property as string or number #35

Open

jmikola opened this issue Apr 1, 2022 · 0 comments

Milestone

Owner

jmikola commented Apr 1, 2022

As discussed in #33:

According to the RFC, the "id" property of a Feature is expected to be a JSON string or a number (https://www.rfc-editor.org/rfc/rfc7946#section-3.2), so I added a check for this. This would be a breaking change, so if you're targeting a 1.1 release instead of a 2.0 release, I can remove the check again.

That change was ultimately not included in #33 since it would be a BC break, but this can be considered for 2.0.

jmikola added this to the 2.0 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment