Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Geolocation examines config.ini for every new lookup #371

Open
adamcandy opened this issue Apr 20, 2020 · 0 comments · May be fixed by #372
Open

Geolocation examines config.ini for every new lookup #371

adamcandy opened this issue Apr 20, 2020 · 0 comments · May be fixed by #372
Labels
bug

Comments

@adamcandy
Copy link
Contributor

If the config.ini does not exist, the [Mapquest] item not in the config file, or the prefer_english_names option not present, the geolocation process checks for the existence of the config and (if present) reads it again on every single new lookup.

See def get_prefer_english_names(): in geolocation.py, lines 122-139.

PR fix to follow.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Optimize location lookup, avoid repeated config reads adamcandy/elodie
2 participants
@jmathai @adamcandy